Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018-11 LWG Motion 13] P0318R1 unwrap_ref_decay and unwrap_reference #2419

Closed
jensmaurer opened this issue Nov 10, 2018 · 4 comments
Closed
Assignees
Milestone

Comments

@jensmaurer
Copy link
Member

jensmaurer commented Nov 10, 2018

P0318R1

@jensmaurer jensmaurer added this to the post-2018-11 milestone Nov 10, 2018
@jwakely
Copy link
Member

jwakely commented Nov 10, 2018

N.B. the proposed wording in this paper is missing a semi-colon after the definition of struct unwrap_ref_decay.

The description for unwrap_reference says:

The member typedef type of unwrap_reference <T> shall equal X& if T equals reference_wrapper<X>, T otherwise.

This should not say "equals" (see #491 and #2354)

@jwakely
Copy link
Member

jwakely commented Nov 11, 2018

The suggested change to [pairs.spec] is

Let Vi is unwrap_ref_decay_t <Ti> .

That should say "be" not "is"

@jwakely
Copy link
Member

jwakely commented Nov 11, 2018

And the changes to the Concurrency TS were not included in the motion to apply this paper, but the suggested change for the TS is wrong too.

@zygoloid
Copy link
Member

Tomasz suggests that more instances of the pattern replaced by this paper are being introduced by other papers moved this week. We should do a pass over the draft after merging the motions to check for more places where this should be applied.

@jensmaurer jensmaurer self-assigned this Nov 15, 2018
zygoloid added a commit that referenced this issue Nov 26, 2018
P0318R1 unwrap_ref_decay and unwrap_reference

Fixes #2419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants