Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018-11 LWG Motion 21] P0591R4 Utility functions to implement uses-allocator construction #2427

Closed
jensmaurer opened this issue Nov 10, 2018 · 4 comments
Assignees
Milestone

Comments

@jensmaurer
Copy link
Member

jensmaurer commented Nov 10, 2018

P0591R4

@jensmaurer jensmaurer added this to the post-2018-11 milestone Nov 10, 2018
@jwakely
Copy link
Member

jwakely commented Nov 10, 2018

The synopsis and the descriptions both say:

template <class T>
auto uses_allocator_construction_args(const Alloc& alloc) -> see below;

The template parameter list is wrong in both places, it needs to be:

template <class T, class Alloc>

@jwakely
Copy link
Member

jwakely commented Nov 10, 2018

Each of the constraints elements should use just pair not std::pair e.g.

Constraints: T is a specialization of std::pair.

@jwakely
Copy link
Member

jwakely commented Nov 11, 2018

The final change in the paper, to [allocator.adaptor.members], is missing the explicit template argument list on the call to uses_allocator_construction_args. It should be uses_allocator_construction_args<T>.

@jensmaurer jensmaurer self-assigned this Nov 16, 2018
@jensmaurer
Copy link
Member Author

This is missing a feature-test macro.

zygoloid added a commit that referenced this issue Nov 26, 2018
P0591R4 Utility functions to implement uses-allocator construction

Fixes #2427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants