New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2018-11 LWG Motion 25] P0896R4 The One Ranges Proposal #2431
Comments
From @CaseyCarter:
|
New information: I've added a P0896R4 tag at the commit from which I generated the document which was moved in plenary to reassure you Editors that you are accessing the proper sources and not something that's been altered since. |
Mateusz Pusz has just pointed out to me that the specification of template<class I>
struct incrementable_traits<const I>
: incrementable_traits<remove_const_t<I>> { }; in which the application of template<class I>
struct incrementable_traits<const I>
: incrementable_traits<I> { }; which has the same normative effect? The specification of |
@zygoloid @jensmaurer @tkoeppe What's the process we should follow when we get a list of sources like this? I think we'd review a diff of the sources first (how??), and if ok, create a PR directly from that. If changes are needed, we'd create a branch from the sources (how??), make the necessary modifications, and create a PR from that. I'm sure there's a way to create a patch from the sources short of creating a PR (or downloading and diffing), I just don't know how - how? |
If the original diff is based on some past commit of our repo here, then it should be possible to apply that diff to a branch at that commit and then rebase that branch to the present. There'd probably be some manual work involved when rebasing, but that should hopefully cover the bulk of the work. |
Sadly, that is not the case. P0896 was created primarily by copying raw sources from the standard and then modifying them in place. Maybe make a branch here, copy over the sources from the stl2 repo, and revert the portion of the resulting changes that replaces swaths of text with |
@burblebee: In short, the eventual goal needs to be a pull request based on a reasonably recent commit of our (not the sources') repository. The sources simply help to get there quicker, for example by being able to cut&paste large chunks of LaTeX source with lots of formatting that would otherwise need to be redone. |
Problem: the wording here uses syntax that CWG motion 4 removes:
I've mailed the lib reflector for advice on how to proceed. |
P0896R4 The One Ranges Proposal Fixes #2431
P0896R4
The text was updated successfully, but these errors were encountered: