Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1224R0 C++ Standard Library Issues to be moved in San Diego except 2697, 2960 and 3134 #2452

Merged
merged 32 commits into from Nov 26, 2018
Merged

P1224R0 C++ Standard Library Issues to be moved in San Diego except 2697, 2960 and 3134 #2452

merged 32 commits into from Nov 26, 2018

Conversation

burblebee
Copy link
Contributor

Fixes #2410.

@jensmaurer jensmaurer added this to the post-2018-11 milestone Nov 13, 2018
@jensmaurer jensmaurer changed the title Motions 2018 11 lwg 4 P1224R0 C++ Standard Library Issues to be moved in San Diego except 2697, 2960 and 3134 Nov 13, 2018
@jensmaurer
Copy link
Member

@burblebee, there is a Travis CI failure showing overfull \hboxes here.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 14, 2018
@burblebee burblebee removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 16, 2018
@tkoeppe tkoeppe self-requested a review November 24, 2018 11:27
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 26, 2018

@zygoloid: beware of a stray space in the commit message of "LWG2936 Path comparison is defined in terms of the generic format" (near the end); something to be fixed during rebasing?

tkoeppe
tkoeppe reviewed Nov 26, 2018
View reviewed changes
source/iostreams.tex Outdated Show resolved Hide resolved
tkoeppe
tkoeppe reviewed Nov 26, 2018
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
@tkoeppe tkoeppe added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 26, 2018
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 26, 2018 •
edited

@zygoloid: beware of the commit message for "LWG3025 Map-like container deduction guides should use pair, not pair" missing the two template argument lists after both instances of "pair"

Also the commit message "LWG3148 should be freestanding" is missing a header name ("").

tkoeppe
tkoeppe reviewed Nov 26, 2018
View reviewed changes
source/algorithms.tex Outdated Show resolved Hide resolved
tkoeppe
tkoeppe reviewed Nov 26, 2018
View reviewed changes
source/algorithms.tex Outdated Show resolved Hide resolved
tkoeppe
tkoeppe reviewed Nov 26, 2018
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
tkoeppe
tkoeppe reviewed Nov 26, 2018
View reviewed changes
source/lib-intro.tex Outdated Show resolved Hide resolved
tkoeppe
tkoeppe reviewed Nov 26, 2018
View reviewed changes
source/time.tex Outdated Show resolved Hide resolved
Dawn Perchik and others added 22 commits November 25, 2018 17:05
@zygoloid
LWG3031 Algorithms and predicates with non-const reference arguments
5d548d4
@zygoloid
LWG3037 polymorphic_allocator and incomplete types
8a8164c
@zygoloid
LWG3038 polymorphic_allocator::allocate should not allow integer over…
492ac2b 
…flow to create vulnerabilities
@zygoloid
LWG3054 uninitialized_copy appears to not be able to meet its excepti…
f244b0b 
…on-safety guarantee

[specialized.algorithms] Comma added.
@zygoloid
LWG3065 LWG 2989 missed that all path's other operators should be hid…
a82b61b 
…den friends as well

[fs.path.nonmember] Note: order of functions has changed since the paper was written.
[fs.class.path] Reordered functions to match said change.
@zygoloid
LWG3096 path::lexically_relative is confused by trailing slashes
753c7e8
@zygoloid
LWG3116 OUTERMOST_ALLOC_TRAITS needs remove_reference_t
74dcfd5
@zygoloid
LWG3122 __cpp_lib_chrono_udls was accidentally dropped
39f93c7
@zygoloid
LWG3127 basic_osyncstream::rdbuf needs a const_cast
36906a0
@zygoloid
LWG3128 strstream::rdbuf needs a const_cast
0fe498e
@zygoloid
LWG3129 regex_token_iterator constructor uses wrong pointer arithmetic
fdfbd44 
[re.tokiter.cnstr] Added Oxford style comma.
@zygoloid
LWG3130 [input.output] needs many addressof
c77cd7e
@zygoloid
LWG3131 addressof all the things
3e67799
@zygoloid
LWG3132 Library needs to ban macros named expects or ensures
17be39b
@zygoloid
LWG3137 Header for __cpp_lib_to_chars
7587ad5
@zygoloid
LWG3140 COMMON_REF is unimplementable as specified
34b5e89
@zygoloid
LWG3145 file_clock breaks ABI for C++17 implementations
304126a
@zygoloid
LWG3147 Definitions of "likely" and "unlikely" are likely to cause pr…
a1eeac3 
…oblems
@zygoloid
LWG3148 <concepts> should be freestanding
18fae1f
@zygoloid
LWG3153 Common and common_type have too little in common
893148c
@zygoloid
LWG3154 Common and CommonReference have a common defect
520d35c
@zygoloid
LWG3160 atomic_ref() = delete; should be deleted
4f6342d
@zygoloid zygoloid merged commit 0eef7e2 into master Nov 26, 2018
@burblebee
Copy link
Contributor Author

@tkoeppe Thanks for your review! And thanks to @zygoloid for fixing all the problems you found!
It shows how important it is to make sure each motion is carefully reviewed by one of us - I think we need a better process to make sure that happens.

@jensmaurer jensmaurer deleted the motions-2018-11-lwg-4 branch October 19, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@timsong-cpp timsong-cpp timsong-cpp left review comments

Assignees
No one assigned
Labels
changes requested Changes to the wording or approach have been requested and not yet applied.
Projects
None yet
Milestone
post-2018-11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@burblebee @jensmaurer @tkoeppe @timsong-cpp @zygoloid