P1141R2 Yet another approach for constrained declarations #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[dcl.fct] Replaced the reference to the non-existant section 17.6.5 with
[temp.over.link] where function template equivalence is defined.
[temp] Clarified "This" as being the "constraint-expression E".
[temp.param] Add reference to "immediately-declared constraint".
[temp.param] Add reference to "the invented type corresponding to the placeholder".
[temp.constr.decl] Added "a" to and "and" after the new item in the bulleted list.
Replace /qualified-concept-name/ with /type-constraint/ in grammar for /return-type-requirement/, and rewrite the new bullet for /return-type-requirement/ added in P1084R2 to use the term immediately-declared constraint introduced in P1141R2.
'immediately-declared constraint' means with an example.
zygoloid
force-pushed
the
motions-2018-11-cwg-15
branch
from
62bb8c6
to
a0a637a
Compare
|
@zygoloid This motion is a good example of why we need a better review process - you caught a few serious mistakes that others missed, but that would have been caught using our old process of having an assigned reviewer to do a thorough review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[dcl.fct] Replaced the reference to the non-existant section 17.6.5 with
[temp.over.link] where function template equivalence is defined.
[temp] Clarified "This" as being the "type-constraint Q".
[temp.param] Add reference to "immediately-declared constraint".
[temp.param] Add reference to "the invented type corresponding to the placeholder".
[temp.constr.decl] Added "a" to and "and" after the new item in the bulletted list.
Fixes #2407.
Note: you might want to fix the spelling of "bulletted" in the commit message when committing to master :)