P0972R0 <chrono> zero(), min(), and max() should be noexcept #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aburch
reviewed
Nov 14, 2018
jensmaurer
added
the
changes requested
|
Should I remove the "changes required" labels now that the typos have been fixed and pushed? I assume an editor will assign themselves to this PR for a final review? |
|
@burblebee: Yes, you can remove the label after the fix. The label is just to call everybody's (including the author's) attention that this is not ready for final review. |
jensmaurer
removed
the
changes requested
zygoloid
force-pushed
the
motions-2018-11-lwg-9
branch
from
59d4384
to
932222d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2415.