Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P0482R6 char8_t: A type for UTF-8 characters and strings #2463

Merged
merged 3 commits into from Nov 25, 2018
Merged

P0482R6 char8_t: A type for UTF-8 characters and strings #2463

merged 3 commits into from Nov 25, 2018

Conversation

jensmaurer
Copy link
Member

Fixes #2403.

@jensmaurer jensmaurer added this to the post-2018-11 milestone Nov 14, 2018
@jensmaurer
Copy link
Member Author

jensmaurer commented Nov 14, 2018 •
edited

Notes:
P1073R3 Immediate functions (pull request #2461) contains a reorganization of the keyword table in [lex.key] as a \multicolfloattable, making further updates easier. It is recommended to apply the other pull request first and then rebase this one.

The paper is missing an update for [atomics.alias], adding a typedef atomic_char8_t. Assuming this is expressly not desired, leaving a fix to an LWG issue.

This has overlap / conflicts with CWG-10 #2402 "P1236R1 Alternative Wording for P0907R4 Signed Integers are Two's Complement". I'd suggest to apply #2402 first and then adjust this pull request.

cubbimew
cubbimew reviewed Nov 14, 2018
View reviewed changes
source/strings.tex Outdated Show resolved Hide resolved
Eelis
Eelis reviewed Nov 15, 2018
View reviewed changes
source/lex.tex Outdated Show resolved Hide resolved
@zygoloid
Copy link
Member

The paper is missing an update for [atomics.alias], adding a typedef atomic_char8_t. Assuming this is expressly not desired, leaving a fix to an LWG issue.

Perhaps I'm missing something, but I don't see why an update to [atomics.alias] would be warranted, since atomic_char8_t is not optional. The paper does update [atomics.syn] as necessary (that update was missing from the pull request; I've added it).

@jensmaurer @zygoloid
P0482R6 char8_t: A type for UTF-8 characters and strings
548ce79 
Rebased on P1236R1 (2018-11 CWG Motion 10): use 'underlying type'
terminology to define char8_t's behavior rather than manually specifying
that it has the same representation as 'unsigned char' three times.
@jensmaurer @zygoloid
[c.mb.wcs] The parameter is called 's', not 'buf'
b4eec9d
@zygoloid zygoloid merged commit 716bee3 into master Nov 25, 2018
@jensmaurer jensmaurer deleted the motions-2018-11-cwg-11 branch October 19, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eelis Eelis Eelis left review comments

@cubbimew cubbimew cubbimew left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2018-11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jensmaurer @zygoloid @Eelis @cubbimew