Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1007R3 std::assume_aligned #2467

Merged
merged 1 commit into from Nov 26, 2018
Merged

P1007R3 std::assume_aligned #2467

merged 1 commit into from Nov 26, 2018

Conversation

burblebee
Copy link
Contributor

[memory.syn] Merged the new function in with [ptr.align] and
renamed the section to "Pointer alignment".
[ptr.aligned] Added "a" before "type similar".

Fixes #2423.

@burblebee
Copy link
Contributor Author

burblebee commented Nov 14, 2018

I fixed the trailing whitespace and committed to the branch - how do I get this PR to see the new change? Note: I didn't rebase and force push since @jwakely said we should no longer do that.

Never mind, github just saw the new commit and is rechecking - cool!!

@jensmaurer
Copy link
Member

jensmaurer commented Nov 14, 2018

@burblebee, please make sure you prefix commit comments with "Fixup:" if you want them squashed by @zygoloid upon merge. (Removing training whitespace certainly qualifies.)

@jensmaurer jensmaurer added this to the post-2018-11 milestone Nov 14, 2018
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 14, 2018

@burblebee: You don't need to take any action. Pull requests are always for branches, not for commits.

@jensmaurer
Copy link
Member

@tkoeppe, right, but I'd like Dawn to avoid the issue going forward.

@burblebee
Copy link
Contributor Author

burblebee commented Nov 16, 2018

@burblebee, please make sure you prefix commit comments with "Fixup:" if you want them squashed by @zygoloid upon merge. (Removing training whitespace certainly qualifies.)

@jensmaurer Thanks for this tip!

@zygoloid, all the commits made after the initial paper in branches motions-2018-11-lwg-16, motions-2018-11-lwg-17, motions-2018-11-lwg-9, and motions-2018-11-lwg-4 should have been prefixed with "Fixup:". Note that in motions-2018-11-lwg-4 you'll want to rebase in order to squash the fixes in with their corresponding issue. I can force push if you prefer.

source/utilities.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 17, 2018
@burblebee burblebee removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 23, 2018
[memory.syn] Merged the new function in with [ptr.align] and
renamed the section to "Pointer alignment".
[ptr.aligned] Added "a" before "type similar".
@zygoloid zygoloid merged commit 1ac1d0d into master Nov 26, 2018
@jensmaurer jensmaurer deleted the motions-2018-11-lwg-17 branch October 19, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants