Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editorial issues. #251

Closed
wants to merge 11 commits into from
Closed

Fix editorial issues. #251

wants to merge 11 commits into from

Conversation

cassioneri
Copy link
Contributor

No description provided.

@jwakely
Copy link
Member

jwakely commented Jan 23, 2014

Hi Cassio, the change to the input iterator requirements should use the orange command (which I assume is "open range" not the colour ;-) rather than tcode, see the next row in the table. The other changes looks correct, so if you can update that in your branch this pull request should update automatically and I'll merge it. Thanks.

@cassioneri
Copy link
Contributor Author

Hi Jonathan,

Ok, I'll fix that asap and let you know.

Many thanks,
Cassio.
On Jan 23, 2014 10:35 AM, "Jonathan Wakely" notifications@github.com
wrote:

Hi Cassio, the change to the input iterator requirements should use the
orange command (which I assume is "open range" not the colour ;-) rather
than tcode, see the next row in the table. The other changes looks
correct, so if you can update that in your branch this pull request should
update automatically and I'll merge it. Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/251#issuecomment-33112812
.

@cassioneri
Copy link
Contributor Author

Hi Jonathan,

I've just updated my branch.

HTH,
Cassio.

On Thu, Jan 23, 2014 at 10:55 AM, Cassio Neri cassio.neri@gmail.com wrote:

Hi Jonathan,

Ok, I'll fix that asap and let you know.

Many thanks,
Cassio.
On Jan 23, 2014 10:35 AM, "Jonathan Wakely" notifications@github.com
wrote:

Hi Cassio, the change to the input iterator requirements should use the
orange command (which I assume is "open range" not the colour ;-) rather
than tcode, see the next row in the table. The other changes looks
correct, so if you can update that in your branch this pull request should
update automatically and I'll merge it. Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/251#issuecomment-33112812
.

@jwakely
Copy link
Member

jwakely commented Feb 20, 2014

I've merged these changes manually (with some changes to the commit messages) so am closing the pull request. You might get a conflict when merging origin/master, but it's easy to resolve.

@jwakely jwakely closed this Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants