Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider moving requires-clause in a template-head onto the same line as the rest of the template-head where profitable #2510

Open
zygoloid opened this issue Nov 26, 2018 · 1 comment
Open

consider moving requires-clause in a template-head onto the same line as the rest of the template-head where profitable #2510

zygoloid opened this issue Nov 26, 2018 · 1 comment

Comments

@zygoloid
Copy link
Member

At the moment, we always start a requires-clause in a template-head on a new line, eg:

template<typename T>
  requires is_object_v<T>
struct something {

We should consider whether we can make declarations shorter without sacrificing readability by combining these on the same line:

template<typename T> requires is_object_v<T>
struct something {

Suggestion: someone should try it, produce some before/after screenshots, then we'll make a decision.
@zygoloid zygoloid added the decision-required A decision of the editorial group (or the Project Editor) is required. label Nov 26, 2018
@zygoloid zygoloid mentioned this issue Nov 26, 2018
Closed
@jensmaurer
Copy link
Member

jensmaurer commented Feb 22, 2019 •
edited

Editorial meeting:

  • If it fits on a single line, we should put that on a single line.
  • Strive for local consistency.
  • Try it out first.

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zygoloid @jensmaurer