Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ranges] Shorten and adjust stable labels #2517

Merged
merged 3 commits into from Nov 26, 2018
Merged

Conversation

jensmaurer
Copy link
Member

Fixes #2513.

@CaseyCarter
Copy link
Contributor

Some of the iterator concept stable names are a bit unmanageable as well, e.g., [iterator.concept.weaklyincrementable]. Maybe use iter uniformly to abbreviate iterator?

I also apologize for [common.alg.req], which has subclauses like [common.alg.req.indirectlycomparable]; LWG universally hated the prior [commonalgoreq], but we could come up with nothing better.

@jensmaurer
Copy link
Member Author

jensmaurer commented Nov 26, 2018

@CaseyCarter, I'll try [common.alg.req.ind.cmp] etc.

Do we even need "common" in front? [alg.req...] seems good enough.

@jensmaurer
Copy link
Member Author

Regarding [iterator.concept.weaklyincrementable]: Regrettably, none of the other stable labels in the vicinity abbreviate "iterator" as "iter". I've abbreviate the stuff at the end a bit.

template<class I>
concept Incrementable = @\seebelow@;

// \ref{iterator.concept.iterator}, concept \tcode{Iterator}
template<class I>
concept Iterator = @\seebelow@;

// \ref{iterator.concept.incrementable}, concept \tcode{Sentinel}
// \ref{iterator.concept.sentinel}, concept \tcode{Sentinel}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@CaseyCarter
Copy link
Contributor

Do we even need "common" in front? [alg.req...] seems good enough.

[alg.req] could be easily confused with [algorithms.requirements], but I'm not concerned that this will be a problem in practice since [alg.req] contains only subclauses and [algorithms.requirements] contains only paragraphs.

Thanks for the cleanup.

@zygoloid zygoloid merged commit 915c784 into cplusplus:master Nov 26, 2018
@jensmaurer jensmaurer deleted the b10 branch November 27, 2018 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants