Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[util.smartptr.hash] at wrong level #252

Closed
W-E-Brown opened this issue Dec 25, 2013 · 2 comments
Closed

[util.smartptr.hash] at wrong level #252

W-E-Brown opened this issue Dec 25, 2013 · 2 comments
Assignees
@jensmaurer

Comments

@W-E-Brown
Copy link
Contributor

At the moment, [util.smartptr.hash] "Smart pointer hash support" is numbered 20.8.2.6, which means it is a subclause of [util.smartptr] "Shared-ownership pointers".

However, [util.smartptr.hash] speaks to hash support for unique_ptr as well as shared_ptr.

I recommend that either:

  1. [util.smartptr.hash] be repositioned to become, say, 20.8.3, or
  2. the section be deleted and its two paragraphs become subclauses of their respective smart pointer sections.
@W-E-Brown W-E-Brown reopened this Dec 25, 2013
@jwakely
Copy link
Member

jwakely commented Jan 21, 2014

If it was up to me I'd move hash<unique_ptr<T,D>> under [unique.ptr] and change the title of [util.smartptr] to Shared pointer hash support. The [util.smartptr] section sounds like it covers both and so would be the right place to add hash<unique_ptr<T,D>> but [util.smartptr] is actually all about shared_ptr (and related pieces such as weak_ptr).

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Apr 20, 2017
@zygoloid
Copy link
Member

zygoloid commented Nov 7, 2017

Decision: remove [util.smartptr] heading and move all of its contents up one level.

@zygoloid zygoloid removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Nov 7, 2017
@jensmaurer jensmaurer self-assigned this Nov 16, 2017
@jensmaurer jensmaurer mentioned this issue Nov 16, 2017
Merged
@jwakely jwakely mentioned this issue Sep 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zygoloid @jwakely @W-E-Brown @jensmaurer