[cmp.categories] Replace 'operator admits' phrasing. #2533
Merged
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eelis
reviewed
Nov 27, 2018
|
Sorry, but I fail to see any issue here worth fixing. My English dictionary defines "admit" as "To be capable <https://en.wiktionary.org/wiki/capable> of; to permit <https://en.wiktionary.org/wiki/permit>", and that makes perfect sense to me in the given context. Why do we need further definition?
By the way, the proposed rewording introduces some notion of intention, for which I can find no justification in this context.
In short, I'm at a loss to understand what's wrong with the plain English reading of what's in the Draft.
… On Nov 27, 2018, at 2:29 PM, Jens Maurer ***@***.***> wrote:
Fixes #2357 <#2357>.
You can view, comment on, or merge this pull request online at:
#2533 <#2533>
Commit Summary
[cmp.categories] Replace 'operator admits' phrasing.
File Changes
M source/support.tex <https://github.com/cplusplus/draft/pull/2533/files#diff-0> (25)
Patch Links:
https://github.com/cplusplus/draft/pull/2533.patch <https://github.com/cplusplus/draft/pull/2533.patch>
https://github.com/cplusplus/draft/pull/2533.diff <https://github.com/cplusplus/draft/pull/2533.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#2533>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADHMmVzzR14jla3mA-u_0hKnyffxBxMtks5uzaCagaJpZM4Y2R4U>.
|
jensmaurer
added
the
decision-required
|
@W-E-Brown, the concern here is that "an operator" admits something, but it seems we should talk about the type having certain properties here, not the operator. |
|
Editorial meeting: Postpone due to concurrent LWG work in this area. |
jensmaurer
removed
the
decision-required
jensmaurer
added
the
needs rebase
jensmaurer
added
decision-required
jensmaurer
commented
Jul 16, 2021
jensmaurer
added
the
changes requested
|
Also drop "intent" if possible. "is intended to support" -> admits |
jensmaurer
removed
the
decision-required
jensmaurer
removed
the
changes requested
wg21bot
added
the
needs rebase
jensmaurer
removed
the
needs rebase
CaseyCarter
suggested changes
Feb 22, 2022
CaseyCarter
approved these changes
Feb 22, 2022
|
@tkoeppe, what about this one? |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2357.