Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use \logop consistently. #2545

Merged
merged 1 commit into from Dec 3, 2018
Merged

Use \logop consistently. #2545

merged 1 commit into from Dec 3, 2018

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Dec 2, 2018

For consistency and readability.

jensmaurer
jensmaurer requested changes Dec 2, 2018
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use \logop in case we want to change the formatting later; see [expr.bit.and].

source/ranges.tex Outdated Show resolved Hide resolved
source/regex.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 2, 2018
@Eelis Eelis changed the title [range.adaptors, re.req] Capitalize operator in "bitwise AND/OR". Use \logop consistently. Dec 3, 2018
@Eelis
Copy link
Contributor Author

Eelis commented Dec 3, 2018

Broadened the scope of the patch, to use \logop in various places.

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 3, 2018
jensmaurer
jensmaurer approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tkoeppe tkoeppe merged commit 1dc0c7d into cplusplus:master Dec 3, 2018
@Eelis Eelis deleted the bitwise branch December 3, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eelis @jensmaurer @tkoeppe