Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[view.interface] Use "inherits"/"derives" consistently. #2546

Merged
merged 1 commit into from Dec 7, 2018
Merged

[view.interface] Use "inherits"/"derives" consistently. #2546

merged 1 commit into from Dec 7, 2018

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Dec 2, 2018

No description provided.

@Eelis
Copy link
Contributor Author

Eelis commented Dec 2, 2018

Hmm, actually it might be even better to say "that is derived from it".

@jensmaurer
Copy link
Member

"that is derived from it" sounds better, and is probably clearer, given the curious recursive template pattern here.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 2, 2018
@Eelis
Copy link
Contributor Author

Eelis commented Dec 3, 2018

Amended

jensmaurer
jensmaurer approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 3, 2018
@zygoloid zygoloid merged commit 9d81b4f into cplusplus:master Dec 7, 2018
@Eelis Eelis deleted the inherits branch December 7, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eelis @jensmaurer @zygoloid