[reverse.iter.cons] Indent consistently with the parent subclause #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
changed the title
|
Barring other changes to [iterators], this is ready. |
|
Thanks, I've rearranged the commits a bit, please rebase. |
JohelEGP
force-pushed
the
iter_reverse
branch
from
73e05e3
to
a71b7d7
Compare
jensmaurer
added
the
tiny
|
@tkoeppe, seems this is ready to go. |
zygoloid
reviewed
Dec 20, 2018
source/iterators.tex
Outdated
| inline constexpr bool disable_sized_sentinel<reverse_iterator<Iterator1>, | ||
| reverse_iterator<Iterator2>> = true; | ||
| requires (!SizedSentinel<Iterator1, Iterator2>) | ||
| inline constexpr bool disable_sized_sentinel<reverse_iterator<Iterator1>, |
There was a problem hiding this comment.
The existing indentation is correct:
- the requires clause should be indented 2 spaces from the line it's continuing (the template-head)
- the variable declaration is a definition, so does not need indentation.
This style would also be acceptable, but is generally used only for non-defining declarations:
template<class Iterator1, class Iterator2>
requires (!SizedSentinel<Iterator1, Iterator2>)
inline constexpr bool disable_sized_sentinel<reverse_iterator<Iterator1>,
reverse_iterator<Iterator2>> = true;
There was a problem hiding this comment.
Dropped that commit.
JohelEGP
force-pushed
the
iter_reverse
branch
from
a71b7d7
to
8dfe4c5
Compare
JohelEGP
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.