Editorial(?) changes in [conversions] #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdutoit
pushed a commit
that referenced
this pull request
Oct 18, 2012
[conversions] Fix formatting issues, extraneous template arguments to the class Codecvt, reference to codecvt_utf8 as a user type (when it's in fact a standard type) in non-normative note and typedef descriptions to match synopsis. Thanks to Jonathan Wakely!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Originally submitted as pull request #22, now resubmitted from a separate branch so I can push other changes without mixing them up.)
The types
byte_stringandwide_stringshould be in a fixed-width typeface.Codecvtis a class not a template, soCodecvt<Elem, char, std::mbstate_t>is ill-formed, it should be justCodecvt(same problem in [conversions.string] and [conversions.buffer].)The example in [conversions.string] supposes the existence of some facet called
codecvt_utf8, which is in the standard library now so there's no need to word it that way. Just usestd::codecvt_utf8.http://cplusplus.github.com/LWG/lwg-defects.html#991 changed the string types to use allocators, but didn't update the definitions so they don't match the class synopsis (are those definitions even necessary? They don't add anything that isn't already defined in the class definition in paragraph 2).
Re-indent an example in [conversions.buffer]
There are also lots of redundant
std::qualifications in that clause, which I didn't remove to keep the patch simpler.If any of these doesn't qualify as editorial changes let me know and I'll request LWG issues and send a new pull request without those parts.