Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decide what to do with underscores in section labels #2609

Closed
zygoloid opened this issue Dec 21, 2018 · 4 comments
Closed

decide what to do with underscores in section labels #2609

zygoloid opened this issue Dec 21, 2018 · 4 comments

Comments

@zygoloid
Copy link
Member

Continuing from #1498, we have 81 section labels containing underscores. These look extremely ugly: the font we use to display section labels does not have a reasonable underscore character.

We should either:

  • change the font used to render section labels (both in the body text and in xrefindex and xrefdelta) to have a less ugly underscore, or
  • revise the section labels to avoid using underscores

Generally when we form a section label from an identifier, we change underscores into periods (eg, [unord.map.syn] not [unordered_map.syn]); fixing these section labels to do the same may be the most consistent option.
@zygoloid zygoloid added the decision-required A decision of the editorial group (or the Project Editor) is required. label Dec 21, 2018
@jensmaurer jensmaurer mentioned this issue Dec 21, 2018
Closed
@jensmaurer
Copy link
Member

Let's revise the section labels, avoiding the underscores.
@tkoeppe consistently talks us out of having more font creativity in the standard.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 21, 2018

That's right :-) I wouldn't be opposed to finding a solution that simply redefines this particular symbol, globally, to a somewhat more size-appropriate underscore, though. As long as we just have one kind of underscore... @godbyk: Any idea how to do that? It's the bold-roman body font that needs fixing.

@jensmaurer jensmaurer mentioned this issue Dec 21, 2018
Merged
@godbyk
Copy link
Contributor

godbyk commented Dec 21, 2018 •
edited

@tkoeppe Yes, we can redefine \textunderscore (which is used behind the scenes when you type _ in non-math mode) to draw our own underscore instead of using one from the font if we don't like the one from the font. By default, a 'fake' underscore is drawn if one isn't available in the font. It may be that the default fake one doesn't fit the design well and we should tweak it.

@timsong-cpp
Copy link
Contributor

Speaking of ugly underscores, maybe we can do something about static_assert-declaration too.

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@godbyk @zygoloid @tkoeppe @timsong-cpp @jensmaurer