Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[range.prim,iterator.container] merge into preceding subclause #2620

Merged
merged 2 commits into from Jan 21, 2019

Conversation

jensmaurer
Copy link
Member

Fixes #2614.

@JohelEGP
Copy link
Contributor

Why not rename the stable labels from "range.prim." to "range.access.", too? They're range accessors too, after all. [ranges.general] would be left using "range primitives", so maybe update that too (and drive-by mention the adaptors, perhaps).

@jensmaurer
Copy link
Member Author

We're trying to keep stable labels, well... stable. Just because the parent subclause has a different label doesn't mean we need to rename the subordinate labels.

@CaseyCarter
Copy link
Contributor

CaseyCarter commented Jan 5, 2019

We're trying to keep stable labels, well... stable.

The stable names in question have only been present in a single revision of the WD. It seems reasonable to me to change them.

@zygoloid zygoloid added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jan 19, 2019
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jan 19, 2019
@JohelEGP
Copy link
Contributor

If you decide to change the stable labels, there are others to consider. The stable names of the non-adaptor CPOs under [range.factories] end in adaptor, rather than factory.

@zygoloid zygoloid merged commit d333390 into cplusplus:master Jan 21, 2019
@jensmaurer jensmaurer deleted the b23 branch January 23, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants