Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expr.prim.id.dtor] Fix comment in example. #2633

Merged
merged 1 commit into from Jan 19, 2019

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Jan 1, 2019

In translation phase 3, the 0.T in the line of code is parsed as a (single) preprocessing-token.

In phase 7, this preprocessing token is converted into a user-defined-floating-literal whose fractional-constant component is 0. and whose ud-suffix component is T.

At no point is the 0. partial token a floating-point literal. At most, it is the fractional-constant component of the bigger user-defined-floating-literal token 0.T.

Fixes #2630.

source/expressions.tex Outdated Show resolved Hide resolved
In translation phase 3, the "0.T" in the line of code is parsed as a (single) preprocessing-token.

In phase 7, this preprocessing token is converted into a user-defined-floating-literal whose ud-suffix component is "T".

At no point is the "0." partial token a floating-point literal. At most, it is the fractional-constant component in a bigger user-defined-floating-literal token.

Fixes cplusplus#2630.
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zygoloid zygoloid merged commit d426489 into cplusplus:master Jan 19, 2019
@Eelis Eelis deleted the ppnumber branch January 19, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[expr.prim.id.dtor] Comment in example reflects lexing misunderstanding
3 participants