Fix some operator<=> declarations with the wrong number of parameters
#2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Jan 2, 2019
Rakete1111
reviewed
Jan 2, 2019
Quuxplusone
commented
Jan 2, 2019
source/classes.tex
Outdated
| friend bool operator==(const C& x, const C& y) = default; // OK, returns \tcode{x <=> y == 0} | ||
| bool operator<(const C&) = default; // OK, function is deleted | ||
| friend bool operator==(const C&, const C&) = default; // OK, returns \tcode{x <=> y == 0} | ||
| friend bool operator<(const C&, const C&) = default; // OK, function is deleted |
There was a problem hiding this comment.
The old version could also have been rescued by adding a trailing const; but I am being no longer apologetic for my love of ADL friends. :)
There was a problem hiding this comment.
As a general rule, we do want to show different coding styles in the core section of the C++ standard. (That's different for the library seciton). So, showing "the other syntax" for operator< seems perfectly fine (yes, it needs a "const").
jensmaurer
reviewed
Jan 4, 2019
jensmaurer
reviewed
Jan 4, 2019
Also one `operator<` that should at least have been a const member function.
|
Ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed one of these mistakes while reading P0732R2; looks like when it was merged, the editor added the missing
operator<=>(correctly) but left off thefriendkeyword (incorrectly).The other I found by grepping the source for "
operator<=>".My understanding is that Herb Sutter's preferred spelling is
auto operator<=>(const T&) const = default;— but that the alternative spellingfriend auto operator<=>(const T&, const T&) = default;is also valid and has approximately the same semantics, and it's not a problem that some examples use one style and some the other.