Use "models" for concepts, and "meets" for non-concept requirements with semantics #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so as to avoid potential confusion.
…pt requirements ...and use "satisfies" only with pure predicates - those without semantic requirements - including concepts when only the syntactic requirements are intended. Fixes cplusplus#2591.
jensmaurer
reviewed
Jan 6, 2019
| Types \tcode{Derived} and \tcode{Base} model | ||
| \tcode{\libconcept{DerivedFrom}<Derived, Base>} when they are class types and | ||
| either \tcode{Derived} is publicly and unambiguously derived from \tcode{Base}, | ||
| or \tcode{Derived} and \tcode{Base} are the same type ignoring cv-qualifiers. |
There was a problem hiding this comment.
Could you extract this change and the following one into a separate pull request, please? This is not strictly a "satisfy" -> "meet" change and therefore makes review harder.
zygoloid
added
needs rebase
|
@CaseyCarter , this needs a bit of work. |
I can get to this tomorrow; have you folks chosen a deadline for the post-Kona draft yet? |
|
Submitting this as separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[updated by @jensmaurer]
Fixes #1263.
Fixes #2591.