Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[algorithms] Qualify declarator-id with sub-namespace. #2656

Merged
merged 1 commit into from Mar 15, 2019

Conversation

jensmaurer
Copy link
Member

Partially addresses #2512.

@jensmaurer
Copy link
Member Author

I've just prefixed the declarator-id, but that exhibits an issue: While the concept names are all in namespace std (good), the return types such as safe_iterator_t or blah_result are not; they are in namespace std::ranges. There are three approaches:

  • transform to trailing return types
  • qualify the return type with "ranges::", too
  • ignore the issue and assume (contrary to compiler behavior) that names in the return type are resolved by starting lookup in the declarator-id's namespace.

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Jan 25, 2019
@jensmaurer
Copy link
Member Author

jensmaurer commented Feb 22, 2019

Editorial meeting:

  • If there is a possibility of confusion, qualify declarator-id and return type etc. No "namespace { }".
  • Otherwise, no change.

@jensmaurer jensmaurer added changes requested Changes to the wording or approach have been requested and not yet applied. needs rebase The pull request needs a git rebase to resolve merge conflicts. and removed decision-required A decision of the editorial group (or the Project Editor) is required. labels Mar 15, 2019
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Mar 15, 2019
Also qualify return types where appropriate.
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Mar 15, 2019
@jensmaurer
Copy link
Member Author

Rebased and return types qualified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants