Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[container.node] Add 3 template keywords for dependent name #2676

Merged

Conversation

birbacher
Copy link
Contributor

On:
[container.node.overview]/4
[container.node.cons]/3.1
[container.node.dtor]/1

On:
[container.node.overview]/4
[container.node.cons]/3.1
[container.node.dtor]/1
@jwakely
Copy link
Member

jwakely commented Feb 22, 2019

Since the template parameters of the class type are not specified, it's not actually clear that the allocator is a dependent type in a node-handle (but in practice it's supposed to be).

@birbacher
Copy link
Contributor Author

Since the template parameters of the class type are not specified, it's not actually clear that the allocator is a dependent type in a node-handle (but in practice it's supposed to be).

The wording in table 70 makes it dependent on the arguments of the container which uses the node handle, so the type must differ in some way.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
@tkoeppe, one for you.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 15, 2019

Thanks!

@tkoeppe tkoeppe merged commit 154f2c5 into cplusplus:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants