Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[string::compare] Use of "smallest" instead of "smaller" #270

Closed
sdutoit opened this issue Feb 12, 2014 · 0 comments · Fixed by #998
Closed

[string::compare] Use of "smallest" instead of "smaller" #270

sdutoit opened this issue Feb 12, 2014 · 0 comments · Fixed by #998

Comments

@sdutoit
Copy link
Contributor

sdutoit commented Feb 12, 2014

[string::compare] says:

Determines the effective length rlen of the strings to compare as the smallest of size() and str.size(). The function then compares the two strings by calling traits::compare(data(), str.data(), rlen).

Elsewhere, we say "smaller" when talking about two values. Fix this here, and look for any other occurrences and fix those too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant