Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P0738R2 I Stream, You Stream, We All Stream for istream_iterator #2714

Merged
merged 1 commit into from Mar 14, 2019
Merged

P0738R2 I Stream, You Stream, We All Stream for istream_iterator #2714

merged 1 commit into from Mar 14, 2019

Conversation

CaseyCarter
Copy link
Contributor

Fixes #2697.

@CaseyCarter
Copy link
Contributor Author

Notably, there are a couple of changes in this paper that had already been made in the working draft: 0 changed to nullptr in some \expects, and the parens already removed from return (tmp); in the effects of operator++(int). These don't materially affect the end product, which is as in the paper.

@CaseyCarter CaseyCarter mentioned this pull request Feb 27, 2019
Closed
@jensmaurer jensmaurer added this to the post-2019-02 milestone Mar 5, 2019
@burblebee burblebee self-assigned this Mar 6, 2019
burblebee
burblebee approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@zygoloid zygoloid changed the base branch from master to motions-2019-02-lwg-6 March 14, 2019 20:18
@zygoloid zygoloid merged commit 5ec9daa into cplusplus:motions-2019-02-lwg-6 Mar 14, 2019
@zygoloid
Copy link
Member

(Transferred to local motion branch.)

@zygoloid zygoloid mentioned this pull request Mar 14, 2019
Merged
@zygoloid
Copy link
Member

Local PR is #2782

@CaseyCarter CaseyCarter deleted the motions-2019-02-lwg-6 branch March 14, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burblebee burblebee burblebee approved these changes

Assignees

@burblebee burblebee

Labels
None yet
Projects
None yet
Milestone
post-2019-02
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CaseyCarter @zygoloid @burblebee @jensmaurer