P1024R3 Usability Enhancements for std::span #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burblebee
requested changes
Mar 6, 2019
JohelEGP
suggested changes
Mar 6, 2019
|
@JohelEGP Thanks for your review! Would you like to have a final review after the last fixes and approve if good? Thanks again! |
burblebee
approved these changes
Mar 8, 2019
Moved the declaration of the undefined partial specialization tuple_size<span<ElementType, dynamic_extent>> to the header synopsis. Fixed missing I template parameter in definition of get<I>. Replaced ptrdiff_t parameters with size_t parameters to match changes made by LWG Motion 15.
zygoloid
force-pushed
the
motions-2019-02-lwg-17
branch
from
c6daceb
to
3649f80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the declaration of the undefined partial specialization
tuple_size<span<ElementType, dynamic_extent>> to the header
synopsis.
Fixes #2708.