Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1252R2 Ranges Design Cleanup #2720

Merged
merged 2 commits into from Mar 15, 2019
Merged

P1252R2 Ranges Design Cleanup #2720

merged 2 commits into from Mar 15, 2019

Conversation

jensmaurer
Copy link
Member

Renamed some suggested stable labels for new sections.

Fixes #2707.

CaseyCarter
CaseyCarter suggested changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this PR!

source/xrefdelta.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/algorithms.tex Outdated Show resolved Hide resolved
@jensmaurer
Copy link
Member Author

@CaseyCarter, thanks for the review!

@jensmaurer jensmaurer added this to the post-2019-02 milestone Mar 5, 2019
@burblebee
Copy link
Contributor

@CaseyCarter, ok to assign this review to you? Please approve when you're happy with it. Thanks!

JohelEGP
JohelEGP suggested changes Mar 6, 2019
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
JohelEGP
JohelEGP reviewed Mar 6, 2019
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
CaseyCarter
CaseyCarter suggested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo @JohelEGP's comments and the ingress paper's failure to add ref_view to <ranges>.

source/ranges.tex Show resolved Hide resolved
burblebee
burblebee requested changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve issue with ref_view (see comments).

burblebee
burblebee reviewed Mar 10, 2019
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done a full review, but it seems I have to "approve" in order to remove my "request changes". alas. ... nope, that didn't work either!

... Had to approve the very last commit in order to remove my red vote :)

@zygoloid zygoloid merged commit 03515b4 into master Mar 15, 2019
@jensmaurer jensmaurer deleted the motions-2019-02-lwg-16 branch October 19, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohelEGP JohelEGP JohelEGP requested changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@burblebee burblebee burblebee approved these changes

Assignees

@CaseyCarter CaseyCarter

Labels
None yet
Projects
None yet
Milestone
post-2019-02
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jensmaurer @burblebee @CaseyCarter @JohelEGP @zygoloid