Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0811R3 Well-behaved interpolation for numbers and pointers #2724

Merged
merged 1 commit into from Mar 14, 2019

Conversation

jensmaurer
Copy link
Member

Fixes #2704.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 13, 2019

Just general concerns with this paper: it's adding something to <cmath>, but it doesn't update any of the wording that things in cmath are also in math.h. E.g. [cmath.syn]p1 probably needs updating? And p2 talks about general additional overloads; does this apply to lerp, too?

@CaseyCarter
Copy link
Contributor

Just general concerns with this paper: it's adding something to <cmath>, but it doesn't update any of the wording that things in cmath are also in math.h. E.g. [cmath.syn]p1 probably needs updating?

This came up in LWG. I may have volunteered to submit an editorial issue to reword [cmath.syn]/1 (I don't precisely recall, and in any case I obviously failed to do so). It's silly for us to say that <cmath> and math.h are the same except for [list of items that we must remember to modify whenever we add something to <cmath>]. Something like:

Much of the header \tcode{<cmath>} is the same as the C standard library header \tcode{<math.h>}.
The entities and macros declared in \tcode{cmath} that are not specified in this 
subclause~\ref{c.math} have the same behavior as in the C standard library\iref{library.c}. 
\begin{note}
Several functions have additional overloads in this document not present in \tcode{<math.h>}, 
but they have the same behavior as in the C standard library.
\end{note}

would be an improvement. (Personally, I'd prefer that we put our additions in <math> instead of <cmath> and stop messing with C's headers, but that bridge was burned long ago.)

And p2 talks about general additional overloads; does this apply to lerp, too?

This also came up in LWG, we were satisfied to apply [cmath.syn]/2 to lerp.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 14, 2019

And p2 talks about general additional overloads; does this apply to lerp, too?

This also came up in LWG, we were satisfied to apply [cmath.syn]/2 to lerp.

Thanks a lot. I wish authors would update their final paper to include decisions like that; it seems like a shame that all this information that had to be discovered will get lost in time.

@zygoloid zygoloid merged commit 6da8552 into master Mar 14, 2019
@jensmaurer jensmaurer deleted the motions-2019-02-lwg-13 branch October 19, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants