P1009R2 Array size deduction in new-expressions #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review completed - see comments below:
|
burblebee
reviewed
Mar 6, 2019
burblebee
approved these changes
Mar 6, 2019
burblebee
reviewed
Mar 6, 2019
| @@ -4542,9 +4539,11 @@ | |||
| the \grammarterm{new-initializer}~(\ref{dcl.init.aggr}, \ref{dcl.init.string}). | |||
|
|
|||
| \pnum | |||
| \indextext{\idxcode{new}}% | |||
| If the \grammarterm{expression} in a \grammarterm{noptr-new-declarator} | |||
| is present, it is implicitly converted to \tcode{std::size_t}. | |||
| \indextext{function!allocation}% | |||
There was a problem hiding this comment.
Do you think this index should precede the new text?
There was a problem hiding this comment.
It's existing stuff, and I'm not too happy about the indexing here in general. I'd like to leave it as-is for now.
zygoloid
force-pushed
the
motions-2019-02-cwg-10
branch
from
74e2a4c
to
c9074b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2690.