Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motions 2019 02 cwg 2 #2737

Merged
merged 24 commits into from Mar 9, 2019
Merged

Motions 2019 02 cwg 2 #2737

merged 24 commits into from Mar 9, 2019

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Mar 5, 2019 •
edited

Fixes #2682.

FYI: CWG2083 Also fixes CWG2103 and CWG2170.

@jensmaurer
Copy link
Member

@burblebee: "All checks have failed".

@jensmaurer jensmaurer added this to the post-2019-02 milestone Mar 5, 2019
cpplearner
cpplearner reviewed Mar 6, 2019
View reviewed changes
source/basic.tex Outdated Show resolved Hide resolved
@burblebee
Copy link
Contributor Author

burblebee commented Mar 6, 2019 •
edited

@burblebee: "All checks have failed".

I rebased on master and it introduced some Overfull and undefined references... [...]

... Never mind - I somehow got things into a bad state - all better now. @zygoloid master is building for me now.

@zygoloid zygoloid self-assigned this Mar 8, 2019
Dawn Perchik and others added 24 commits March 8, 2019 16:04
@zygoloid
CWG581 Can a templated constructor be explicitly instantiated or spec…
2124f87 
…ialized?
@zygoloid
CWG1937 Incomplete specification of function pointer from lambda
c9cb45e 
[expr.prim.lambda.closure]p9 Repeat F for clarity.
@zygoloid
CWG1938 Should hosted/freestanding be implementation-defined?
942f88d 
[compliance]p1 Add a semi-colon to separate the two statements.
@zygoloid
CWG2020 Inadequate description of odr-use of implicitly-invoked funct…
764dcea 
…ions
@zygoloid
[basic.def.odr] Apply additional edits from CWG review that were not
cbb21fb 
transcribed into P1359R0.
@zygoloid
CWG2051 Simplifying alias rules
573152d
@zygoloid
CWG2083 Incorrect cases of odr-use
f088588 
Also fixes CWG2103 and CWG2170.
@zygoloid
CWG2257 Lifetime extension of references vs exceptions
64c2c12
@zygoloid
CWG2266 Has dependent type vs is type-dependent
c3bf5f5
@zygoloid
[temp.dep.type] Rephrase to avoid suggesting that an expression can be
5f7461d 
the current instantiation.

A type can't be the current instantiation either, but that's a
pre-existing prevalent problem.
@zygoloid
CWG2289 Uniqueness of structured binding names
595b8b0
@zygoloid
CWG2353 Potential results of a member access expression for a static …
e6f307b 
…data member

[basic.def.odr] Note: some referenced wording was removed in CWG2083.
@zygoloid
CWG2354 Extended alignment and object representation
e8ed1eb
@zygoloid
CWG2365 Confusing specification for dynamic_cast
e81049e
@zygoloid
CWG2368 Differences in relational and three-way constant comparisons
f6ff9bc
@zygoloid
CWG2372 Incorrect matching rules for block-scope extern declarations
7218980
@zygoloid
CWG2379 Missing prohibition against constexpr in friend declaration
d4f472e
@zygoloid
CWG2380 capture-default makes too many references odr-usable
9788ef3
@zygoloid
CWG2381 Composite pointer type of pointers to plain and noexcept memb…
93e0356 
…er functions
@zygoloid
CWG2384 Conversion function templates and qualification conversions
73ccc57
@zygoloid
CWG2385 Lookup for conversion-function-ids
66ea6eb
@zygoloid
CWG2386 tuple_size requirements for structured binding
498092c
@zygoloid
CWG2387 Linkage of const-qualified variable template
a7a531a 
[basic.link] Added Oxford comma.
@zygoloid
CWG2394 Const-default-constructible for members
8bc56e3
@zygoloid
Copy link
Member

zygoloid commented Mar 9, 2019

Force-pushed with fixes:

CWG1938: Expanded on implementation-defined behavior index entry
CWG2020: P1359R0 missed two edits from the version discussed in CWG (confirmed with Mike), missing formatting for id-expression
CWG2051: Add an "or" before the last bullet
CWG2266: The object expression cannot be the current instantiation (that's a name, not an expression)
CWG2380: Inconsistent punctuation after "error"
CWG2381: "noexcept" missing code font
CWG2386: "value" missing code font

@zygoloid zygoloid merged commit 0b326cd into master Mar 9, 2019
@jensmaurer jensmaurer deleted the motions-2019-02-cwg-2 branch October 19, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpplearner cpplearner cpplearner left review comments

Assignees

@zygoloid zygoloid

Labels
None yet
Projects
None yet
Milestone
post-2019-02
Development

Successfully merging this pull request may close these issues.

[2019-02 CWG Motion 2] P1359R0 Core Language Working Group "tentatively ready" Issues (Kona 2019)
5 participants
@burblebee @jensmaurer @zygoloid @tkoeppe @cpplearner