P1041R4 Make char16_t/char32_t string literals be UTF-16/32 #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Mar 7, 2019
jensmaurer
reviewed
Mar 7, 2019
jensmaurer
requested changes
Mar 7, 2019
There was a problem hiding this comment.
Not done: "Furthermore, replace all instances of char16_t string literal with UTF-16 string literal, all instances of char32_t string literal with UTF-32 string literal, all instances of char16_t character literal with UTF-16 character literal, and all instances of char32_t character literal with UTF-32 character literal."
zygoloid
force-pushed
the
motions-2019-02-cwg-6
branch
from
cf69613
to
facaa17
Compare
[lex.string] Removed term "char8_t string literal", replacing with UTF-8 string literal throughout, for consistency.
zygoloid
force-pushed
the
motions-2019-02-cwg-6
branch
from
facaa17
to
0e6ff4b
Compare
|
Jens' comments addressed. I also removed the term " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2686.