Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motions 2019 02 lwg 2 #2745

Merged
merged 13 commits into from Mar 14, 2019
Merged

Motions 2019 02 lwg 2 #2745

merged 13 commits into from Mar 14, 2019

Conversation

burblebee
Copy link
Contributor

Fixes #2711.

Drafting notes:

  • LWG3180: I didn't indent "using" (as we had discussed in Kona), in order to be consistent with the existing coding style.
  • LWG3112: I used \hfill\break to workaround an Overfull issue. Is there a better way to do this?

@jensmaurer
Copy link
Member

Maybe just \linebreak?

@jensmaurer jensmaurer added this to the post-2019-02 milestone Mar 5, 2019
source/atomics.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
@burblebee
Copy link
Contributor Author

Maybe just \linebreak?

@jensmaurer \linebreak doesn't work, because it causes the line to expand to full the entire line between the margins (causing severe underfull). The \hfill gets it to fill the rest of the line with spaces apparently (a trick I found from the \br macro which is only active in lib tables apparently). Seems like this is a question for the Latex experts, @tkoeppe ?

@godbyk
Copy link
Contributor

godbyk commented Mar 8, 2019

@burblebee A couple quick options to consider (in order of preference):

  1. Set \emergencystretch. This value is used by TeX only when typesetting paragraphs with overfull lines and allows TeX to add extra interword space to stretch a line out beyond what the normal line-breaking parameters permit. Note that an overfull line warning may still be logged but the line won't actually be overfull when typeset. This option could be applied globally to the document with minimal impact.
  2. Use the sloppypar environment. This employs the \emergencystretch parameter above as well as a few other line-breaking parameters to relax the line-breaking algorithm a bit. Wrap troubleblesome paragraphs in this environment to avoid overfull line warnings altogether. This option should be used only where necessary. Don't use \sloppy globally as it will adversely impact the readability of the document generally.

Finally, if we're running into problems with line-breaking bits of C++ code, we might want to look into better options such as introducing more line break points (e.g., after colons). It might also be worth considering how line-breaking code impacts readability—namely, does the introduction of a hyphen ever cause ambiguity or readability problems?

@jensmaurer
Copy link
Member

@burblebee: Just \newline works nicely (it's \hfill + \linebreak)

@burblebee
Copy link
Contributor Author

@jensmaurer @godbyk thanks for the tip guys!

@tkoeppe tkoeppe assigned tkoeppe and unassigned tkoeppe Mar 13, 2019
@tkoeppe tkoeppe self-requested a review March 13, 2019 22:33
@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 13, 2019

@burblebee: The commit for LWG3077 only seems to modify string, but not deque and vector, as the issue says.

source/strings.tex Outdated Show resolved Hide resolved
source/concepts.tex Outdated Show resolved Hide resolved
@zygoloid zygoloid merged commit cb67ff1 into master Mar 14, 2019
@jensmaurer jensmaurer deleted the motions-2019-02-lwg-2 branch October 19, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants