Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[func.not_fn], [func.bind_front] fix phrasing of \mandates and \expects #2750

Merged
merged 1 commit into from Mar 15, 2019
Merged

[func.not_fn], [func.bind_front] fix phrasing of \mandates and \expects #2750

merged 1 commit into from Mar 15, 2019

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Mar 7, 2019

The Mandates: element should just state its condition, not say that it
"shall be true". Cpp17 concept requirements should be phrased as "X meets the
Y requirements" not "X shall meet the requirements of Y".

@jwakely
[func.not_fn], [func.bind_front] fix phrasing of \mandates and \expects
504cd6e 
The Mandates: element should just state its condition, not say that it
"shall be true". Cpp17 concept requirements should be phrased as "X meets the
Y requirements" not "X shall meet the requirements of Y".
@W-E-Brown
Copy link
Contributor

W-E-Brown commented Mar 7, 2019 via email

@jwakely
Copy link
Member Author

jwakely commented Mar 7, 2019

It is my understanding that we do need to say "is true" (but not "shall be").

Yes, the commit message could have been clearer, but the actual commit does change it to "is true".

@zygoloid zygoloid merged commit 721f2d6 into cplusplus:master Mar 15, 2019
@jwakely jwakely deleted the bind_front_mandates branch January 22, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwakely @W-E-Brown @zygoloid