Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[range.iota,range.adaptors] Add cross-references for private member t… #2765

Merged
merged 1 commit into from Mar 15, 2019
Merged

[range.iota,range.adaptors] Add cross-references for private member t… #2765

merged 1 commit into from Mar 15, 2019

Conversation

jensmaurer
Copy link
Member

Fixes #2716.

JohelEGP
JohelEGP suggested changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All but the first four added lines miss that the referred member are templates. The referred clauses correctly start with "class template".

source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
@CaseyCarter
Copy link
Contributor

split_view::outer_iterator::value_type is another case. It currently has a trailing // see \ref{range.split.outer.value} comment, which should be changed to be consistent with the style of this PR.

@zygoloid
Copy link
Member

Merging now for post-Kona, let's make further fixes in a separate PR.

@zygoloid zygoloid merged commit d7d2580 into cplusplus:master Mar 15, 2019
@JohelEGP JohelEGP mentioned this pull request Mar 15, 2019
Closed
@jensmaurer jensmaurer deleted the b18 branch March 15, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohelEGP JohelEGP JohelEGP requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jensmaurer @CaseyCarter @zygoloid @JohelEGP