Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lex.charset fixes #2768

Merged
merged 1 commit into from Nov 26, 2019
Merged

Lex.charset fixes #2768

merged 1 commit into from Nov 26, 2019

Conversation

zygoloid
Copy link
Member

Fixes #2752.

@zygoloid zygoloid changed the base branch from master to motions-2019-02-cwg-6 March 11, 2019 23:32
@zygoloid zygoloid changed the base branch from motions-2019-02-cwg-6 to master March 11, 2019 23:32
@zygoloid
Copy link
Member Author

image

@zygoloid zygoloid added the sg16 Issues needing review from SG16 (Unicode) label Mar 11, 2019
@rmartinho
Copy link

Instead of "(hexadecimal)", what about $[\mathrm{D800}, \mathrm{DFFF}_16]$ instead? (pardon if my LaTeX is too rusty, but _ makes subscripts, right?)

@jensmaurer
Copy link
Member

We're not doing "16" as subscript anywhere else in the standard, as far as I know. Maybe this single location (and in a note) is not a good place to start.

jensmaurer
jensmaurer approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an improvement.

source/lex.tex Show resolved Hide resolved
@jensmaurer
Copy link
Member

Oh, and please change the commit comment to use a "[lex.charset]" prefix.

@tahonermann
Copy link
Contributor

@zygoloid, I see this issue is marked as needing review from SG16. I'm assuming you're just looking for any comments SG16 participants might have to offer. If you would like something more formal, please let me know.

@jensmaurer
Copy link
Member

@tahonermann: Specifically, since you are chair of SG16, do you feel this change should be reviewed by SG16? If not, could you please review it and comment whether you're ok with the change?

@tahonermann
Copy link
Contributor

@jensmaurer @zygoloid, I see no need for this change to be further reviewed by SG16. I have reviewed it and am happy with it.

@jensmaurer jensmaurer removed the sg16 Issues needing review from SG16 (Unicode) label Jun 20, 2019
@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Sep 30, 2019
@jensmaurer
Copy link
Member

Please rebase and fix the conflicts, then force-push.

@zygoloid
[lex.charset] Fix various issues with the description of UCNs.
32511c7 
Clarify that \U sequences not beginning 00 are ill-formed. Clarify
handling of code points naming reserved or noncharacter code points.
Remove unnecessary circumlocution through "short identifiers" by
directly talking about code points. Use code point values directly
rather than using C++ 0x notation.

[lex.string] Fix description of what UCNs mean, and convert it to a
note.
@zygoloid zygoloid merged commit 029f630 into cplusplus:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lex.charset] p2 \00NNNNNN should use placeholder
4 participants
@zygoloid @rmartinho @jensmaurer @tahonermann