Simplifying [class.rel] wording. #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
reviewed
Mar 15, 2019
source/classes.tex
Outdated
| results in an ambiguity | ||
| or a function that is deleted or inaccessible from the operator function, | ||
| or | ||
|
|
||
| \item | ||
| the operator \tcode{@} | ||
| cannot be applied to the return type of \tcode{x <=> y} or \tcode{y <=> x}. | ||
| \tcode{x <=> y @ 0} is ill-formed. |
There was a problem hiding this comment.
This fully covers the check in the first bullet, but it also covers some other things (overload resolution can succeed and pick a function that is nonetheless not callable). As such, changing to this wording is also non-editorial. =(
I think we should just drop the "or y <=> x" from this bullet for now.
There was a problem hiding this comment.
Core issue it is then 😃
zygoloid
added
the
changes requested
jensmaurer
removed
the
changes requested
|
Changes have been applied; commits need squashing. |
|
As in... you want me to force push? Why not squash merge? |
|
I imagine Jens' comment was a reminder to me to squash rather than just rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xandyhave the same type (this is in the context of a defaulted relational operator, so they have to be per [class.compare]/1). So eitherx <=> yfinds something or it doesn't - there's no situation where we'd select the reversed candidatey <=> x, so we can simplify this wording. Same thing Richard pointed out http://lists.isocpp.org/core/2019/03/5706.php about defaulted!=.Also, we never changed that
x <=> y @ 0is actually convertible tobool, so added that too.