Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta.type.synop] Align type_identity_t's "=" with following declarat… #2784

Merged
merged 5 commits into from Mar 15, 2019

Conversation

CaseyCarter
Copy link
Contributor

…ions

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 14, 2019

gnah, this sort of cutespacing is so dubious. It's hard to maintain, and when you're aligning with something that's separated by an intervening line, is it really an improvement, or does it just look like an accident? Eventually you'll form arbitrary bubbles of local alignment separated by harsh domain walls, and it becomes distracting.

Several container class definitions do the same questionable thing.

I'd semi-mildly prefer to get rid of all this and just use regular spacing everywhere.

@CaseyCarter
Copy link
Contributor Author

I'm also not a fan, but it's obviously the intent that this = aligns with the others, so I submitted a fix. Might I suggest we apply this for now, and I'll open an editorial issue to discuss under what circumstances we allow/require alignment in declarations so we can enforce some consistency?

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 15, 2019

OK, but I expect we'll have hundreds more small whitespace fixes in utilities... could you at least have a quick look around the neighbourhood if anything else needs fixing while we're here?

@zygoloid zygoloid merged commit 71c1982 into cplusplus:master Mar 15, 2019
@CaseyCarter CaseyCarter deleted the meta_syn_align branch March 15, 2019 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants