Library-wide: Use "meet" for non-concept type requirements #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
added
the
needs rebase
jwakely
approved these changes
Jun 12, 2019
|
@CaseyCarter Any chance you could rebase this in the next day or so, for the pre-Cologne working draft? |
I'm taking a look now (I hadn't noticed the tag). It looks like mostly conflicts with the table label rework; this shouldn't be much trouble to fix up. |
...instead of "satisfy". Partially addresses cplusplus#1263.
|
Rebased. |
jensmaurer
removed
the
needs rebase
zygoloid
reviewed
Jun 17, 2019
source/time.tex
Outdated
| @@ -1335,7 +1335,7 @@ | |||
| The defaulted copy constructor of duration shall be a | |||
| constexpr function if and only if the required initialization | |||
| of the member \tcode{rep_} for copy and move, respectively, would | |||
| satisfy the requirements for a constexpr function. | |||
| meet the requirements for a constexpr function. | |||
There was a problem hiding this comment.
This one should be "satisfy". See [dcl.constexpr]/3,4,6 and [class.copy.ctor]/12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of "satisfy".
Partially addresses #1263.