Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dcl.type.elab] Mix struct/class in example #2808

Merged
merged 1 commit into from Jun 12, 2019

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Mar 28, 2019

Extend the example to show that the choice of class or struct in an
elaborated-type-name referring to a class is not significant.

Extend the example to show that the choice of 'class' or 'struct' in an
elaborated-type-name referring to a class is not significant.
@jwakely
Copy link
Member Author

jwakely commented Mar 28, 2019

I've seen it suggested that the sentence before the example isn't entirely unambiguous:

either the class or struct class-key shall be used to refer to a class ([class]) declared using the class or struct class-key.

I think it's entirely unambiguous, but the example would reinforce the point, and seems to be in the spirit of core examples not following consistent styles of brace placement, ptr-declarator placement etc.

@jwakely
Copy link
Member Author

jwakely commented Mar 28, 2019

We could also consider switching the order in that wording:

either the class or struct class-key shall be used to refer to a class ([class]) declared using the struct or class class-key.

😈

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with the example for now.

@zygoloid zygoloid merged commit 85f634a into cplusplus:master Jun 12, 2019
@jwakely jwakely deleted the class-key-example branch June 12, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants