Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[istream.sentry] Remove unreferenced typedef-name traits_type #2818

Merged
merged 1 commit into from Jun 12, 2019
Merged

[istream.sentry] Remove unreferenced typedef-name traits_type #2818

merged 1 commit into from Jun 12, 2019

Conversation

CaseyCarter
Copy link
Contributor

I have no idea how this got here - it was in the initial git commit - or why it isn't \\expos, but in any case it's unused.

jwakely
jwakely approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, it's been there since C++98, so long before the initial git commit. We actually make that member public in our sentry, but I agree with removing it from the draft.

@CaseyCarter
Copy link
Contributor Author

We actually make that member public in our sentry

We have no such member; I'm "standardizing existing practice".

jensmaurer
jensmaurer approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkoeppe?

@zygoloid zygoloid merged commit a0f56d5 into cplusplus:master Jun 12, 2019
@CaseyCarter CaseyCarter deleted the sentry_traits branch June 13, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CaseyCarter @jwakely @jensmaurer @zygoloid