Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add forward declaration of atomic class for atomic<shared_ptr<T>> (P0718R2) #2824

Merged
merged 1 commit into from Apr 11, 2019
Merged

add forward declaration of atomic class for atomic<shared_ptr<T>> (P0718R2) #2824

merged 1 commit into from Apr 11, 2019

Conversation

faithandbrave
Copy link
Contributor

http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0718r2.html

Or, I think the synopsis needs forward declaration of atomic class for specialization.

@faithandbrave faithandbrave mentioned this pull request Apr 11, 2019
Closed
jwakely
jwakely requested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need for <atomic> to be included. Implementations are responsible for making it work. Just adding template<class T> struct atomic; is all that's needed.

@faithandbrave
Copy link
Contributor Author

OK. I'll fix and rebase.

@faithandbrave faithandbrave changed the title add missing include <atomic> in <memory> (P0718R2) add forward declaration of atomic class for atomic<shared_ptr<T>> (P0718R2) Apr 11, 2019
@faithandbrave
Copy link
Contributor Author

fixed

jwakely
jwakely approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me now.

@tkoeppe tkoeppe merged commit d45c031 into cplusplus:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@faithandbrave @jwakely @tkoeppe