Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ranges.dangling] Fix namespace of ranges::dangling #2829

Merged
merged 1 commit into from May 1, 2019

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Apr 16, 2019

Fixes #2828

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change per se looks good, but does look a bit normative. Are we sure this is the original intent?

@jwakely
Copy link
Member Author

jwakely commented Apr 16, 2019

The synopsis seems clear. I also checked the cmcstl2 implementation, which puts this type in the same namespace as everything else from the ranges library, and I asked Casey to review it to get his take as the author.

@CaseyCarter
Copy link
Contributor

The intent of P1252 was to restore the usage of dangling from early revisions of P0896, but with a different definition for dangling itself that is more acceptable to LEWG. dangling was defined in std::ranges in P0896r1, so the mistake in P1252 was the detailed specification placing the definition in std and not the synopsis placing the declaration in std::ranges.

@jensmaurer jensmaurer merged commit f3d9056 into cplusplus:master May 1, 2019
@jwakely jwakely deleted the issue-2828 branch May 1, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ranges.syn][range.dangling] contradictory specification for "dangling"
3 participants