Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[temp.deduct.guide] CWG 2422: deduction-guide grammar fix #2839

Closed

Conversation

brevzin
Copy link
Contributor

@brevzin brevzin commented Apr 22, 2019

A deduction-guide should have a conditional explicit-specifier rather than a conditional explicit - this is just oversight from P0892.

After P0892, a _deduction-guide_ should have a conditional _explicit-specifier_ rather than conditional `explicit`
@brevzin
Copy link
Contributor Author

brevzin commented Apr 22, 2019

Hopefully this counts as editorial? I think the design direction is clear here, and we even have wording in like [over.match.class.deduct] which says:

If the function or function template was generated from a constructor or deduction-guide that had an explicit-specifier, each such notional constructor is considered to have that same explicit-specifier.

@brevzin brevzin changed the title deduction-guide grammar fix [temp.deduct.guide] deduction-guide grammar fix Apr 26, 2019
@jensmaurer
Copy link
Member

This looks good to me, but changing grammar feels like a non-editorial change.

On the other hand, [over.match.class.deduct] already assumes that a deduction-guide has an explicit-specifier:

... If the function or function template was generated from a constructor or deduction-guide that had an explicit-specifier, each such notional constructor is considered to have that same explicit-specifier. ...

@zygoloid ?

@zygoloid zygoloid added the cwg Issue must be reviewed by CWG. label Apr 30, 2019
@zygoloid
Copy link
Member

This definitely needs at least CWG review. I don't feel entirely comfortable making a grammar change such as this editorially, even though I think it would be within editorial remit to do so; unless CWG strongly wants this fixed editorially, I'd prefer that this go through the core issue process.

@brevzin
Copy link
Contributor Author

brevzin commented Apr 30, 2019

I don't understand what the "core issue process" actually is.

I sent an email to the Core list describing this issue. It got one response. I assume at this point the thread is just dead. This seems to be fairly typical. So I went ahead and just opened a PR since other parts of the wording already assume this to be the case.

@jensmaurer
Copy link
Member

Sent a reminder e-mail to Mike Miller.

@brevzin
Copy link
Contributor Author

brevzin commented Jun 24, 2019

Just a friendly and encouraging ping, @jensmaurer @zygoloid. Is there an issue for this? How do I make one?

@jensmaurer jensmaurer changed the title [temp.deduct.guide] deduction-guide grammar fix [temp.deduct.guide] CWG 2422: deduction-guide grammar fix Aug 19, 2019
@jensmaurer
Copy link
Member

This is CWG 2422.

@jensmaurer
Copy link
Member

Fixed with 7c9d35d

@jensmaurer jensmaurer closed this Nov 21, 2019
@brevzin brevzin deleted the deduction-guide-cond-explicit branch November 25, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cwg Issue must be reviewed by CWG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants