Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iterator.synopsis][insert.iterator] Some "iterator_t" should be replaced with "ranges::iterator_t" #2859

Closed
frederick-vs-ja opened this issue May 2, 2019 · 1 comment · Fixed by #2860
Closed

[iterator.synopsis][insert.iterator] Some "iterator_t" should be replaced with "ranges::iterator_t" #2859

frederick-vs-ja opened this issue May 2, 2019 · 1 comment · Fixed by #2860
Assignees
@frederick-vs-ja

Comments

@frederick-vs-ja
Copy link
Contributor

In N4810, the specifications for insert_iterator and inserter refer the name iterator_t which belongs to namespace std::ranges.
However, insert_iterator and inserter are in namespace std themselves.
So I think iterator_t should be qualified with ranges:: while introducing insert_iterator and inserter.
@jwakely
Copy link
Member

jwakely commented May 2, 2019

Good catch, thanks. Would you be able to submit a pull request to fix it?

@frederick-vs-ja frederick-vs-ja mentioned this issue May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frederick-vs-ja frederick-vs-ja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[iterators] Add "ranges::" for "iterator_t"
2 participants
@jwakely @frederick-vs-ja