Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[concept.swappable] Strike array poison pill swap overload #2887

Merged
merged 1 commit into from Jun 12, 2019

Conversation

CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented May 21, 2019

Since lookup is only performed when at least one argument has class or enumeration type, template argument deduction can never succeed for the poisin pill overload with two parameters of reference-to-array type; it can be struck with no normative impact.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained above, I'm not yet convinced that this bullet will never be invoked.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label May 21, 2019
@CaseyCarter CaseyCarter deleted the swap_pill branch May 21, 2019 17:26
@CaseyCarter CaseyCarter restored the swap_pill branch May 21, 2019 17:56
@CaseyCarter CaseyCarter reopened this May 21, 2019
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label May 22, 2019
@jensmaurer
Copy link
Member

So, after the detour, could you please fix the intro sentence for the pull request?
"will never be selected by overload resolution" is slightly misleading; we want to say "template argument deduction will never succeed for both parameters".

Since lookup is only performed when at least one argument has class or enumeration type, template argument deduction can never succeed for the poisin pill overload with two parameters of reference-to-array type; it can be struck with no normative impact.
@CaseyCarter
Copy link
Contributor Author

could you please fix the intro sentence for the pull request?

Updated in the first post and the commit message.

@jensmaurer
Copy link
Member

Thanks. That's as much preparation I can do for this right now, but this is certainly for @zygoloid to apply.

@zygoloid zygoloid merged commit 373176c into cplusplus:master Jun 12, 2019
@CaseyCarter CaseyCarter deleted the swap_pill branch June 12, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants