[styles] Also allow 'listings' package v1.8b #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does changing this file make "copied verbatim from listings.sty version 1.6 except where commented" untrue? Was it already untrue? |
|
The change itself looks fine, I just wonder if we should adjust the comment I quoted, or add a comment about the newer versions that are allowed. |
|
I just followed the previous change: #2473 |
|
@jwakely, the comment is still correct: What we have is copied, but if it also works with the subsequent versions, all is well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacTex 2019 comes with listings in version 1.8b. Without this change, it does not compile.