Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_partitioned in mutating sequence operations #289

Closed
sdutoit opened this issue Mar 27, 2014 · 1 comment
Closed

is_partitioned in mutating sequence operations #289

sdutoit opened this issue Mar 27, 2014 · 1 comment
Assignees
@jensmaurer

Comments

@sdutoit
Copy link
Contributor

sdutoit commented Mar 27, 2014

Stephen Howe writes:

is_partitioned() is under in section 25.3.13, which is under 25.3 “Mutating sequence operations”

Well there is something wrong with this classification as is_partitioned() does not change the sequence.
is_partitioned() should be under 25.2 “Non-modifying sequence operations”
@k-satoda
Copy link
Contributor

k-satoda commented Aug 2, 2014

partition_point() is under the same situation.

I think 25.4 [alg.sorting] is more appropriate place because "is partitioned" requirement is defined there, and partition_point() is in fact the most generalized version of other binary search algorithms (lower_bound(), upper_bound(), and binary_search()).

jensmaurer added a commit to jensmaurer/draft that referenced this issue Dec 14, 2016
@jensmaurer
[algorithms] Move non-modifying algorithms away
9507827 
from [alg.modifying.operations].

For is_partitioned, create a new subsection [alg.is_partitioned]
under [alg.nonmodifying].
For partition_point, create a new subsection [partition.point]
under [alg.binary.search].

Fixes cplusplus#289.
@jensmaurer jensmaurer mentioned this issue Dec 14, 2016
Merged
@jensmaurer jensmaurer self-assigned this Dec 14, 2016
jensmaurer added a commit to jensmaurer/draft that referenced this issue Jan 12, 2017
@jensmaurer
[alg.partitions] Move entire subclause to [alg.sorting].
5de3e09 
The non-modifying operation is_partitioned doesn't fit into
'mutating sequence operations', and partitioning can be
considered a weak sort.

Fixes cplusplus#289.
zygoloid pushed a commit that referenced this issue Feb 4, 2017
@jensmaurer @zygoloid
[alg.partitions] Move entire subclause to [alg.sorting]. (#1245)
43c20db 
The non-modifying operation is_partitioned doesn't fit into
'mutating sequence operations', and partitioning can be
considered a weak sort.

Fixes #289.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sdutoit @k-satoda @jensmaurer