Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[concept.booolean] LWG 3208: Reorder expression requirements consistently #2890

Closed
wants to merge 1 commit into from

Conversation

CaseyCarter
Copy link
Contributor

...to improve readability.

I should point out that this technically has normative impact due to the short-circuiting nature of requires-expressions: there are sets of borderline-pathological parameters which would have failed to satisfy the prior formulation that would result in an ill-formed program with the proposed formulation, and vice versa. I can confirm that the design intent is that the first two compound-requirements precede the others and that the order of the others is not significant, but I'll of course understand if the editors would like LWG to give this change the nod.

@jensmaurer
Copy link
Member

@zygoloid, is this editorial?

@jensmaurer jensmaurer added the lwg Issue must be reviewed by LWG. label Jun 5, 2019
@jensmaurer
Copy link
Member

Editorial meeting: We want a more general statement in the library front matter that substitution order in library concepts is not guaranteed, so that reorderings like the one we're discussing here are clearly editorial. @CaseyCarter , could you please make such an LWG issue happen?

@CaseyCarter
Copy link
Contributor Author

Editorial meeting: We want a more general statement in the library front matter that substitution order in library concepts is not guaranteed, so that reorderings like the one we're discussing here are clearly editorial. @CaseyCarter , could you please make such an LWG issue happen?

Definitely not: there are cases in which the correct functioning of concepts depends on substitution order. I'm happy for such reorderings to remain non-editorial.

(Should I close this PR and resubmit as an LWG issue, or assume that the addition of the "lwg" tag implies that LWG has already been informed of this PR and asked to handle it?)

@jensmaurer
Copy link
Member

@CaseyCarter , thanks.

Your statement means we can't editorially decide whether some order was intentional or not. So, please make this particular reordering an LWG issue. No, the label just means "we think it's an LWG issue" to prevent us from applying something in this area editorially.

Once you have an LWG issue number, feel free to put that in a comment here.

@jensmaurer jensmaurer added the not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking. label Jun 6, 2019
@CaseyCarter
Copy link
Contributor Author

The proposed change is now the P/R of LWG 3208.

@CaseyCarter CaseyCarter closed this Jun 6, 2019
@CaseyCarter CaseyCarter deleted the boolean_reorder branch June 6, 2019 21:12
@jensmaurer jensmaurer changed the title [concept.booolean] Reorder expression requirements consistently [concept.booolean] LWG 3208: Reorder expression requirements consistently Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lwg Issue must be reviewed by LWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants