Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits missing from N3789 #291

Closed
sdutoit opened this issue Mar 29, 2014 · 0 comments
Closed

Edits missing from N3789 #291

sdutoit opened this issue Mar 29, 2014 · 0 comments
Milestone
2014 pre-Rappersw...

Comments

@sdutoit
Copy link
Contributor

sdutoit commented Mar 29, 2014

STL writes:

Hi,

N3789 "Constexpr Library Additions: functional" was voted into the WP in Chicago, but it wasn't completely applied.

I've verified that these are the edits missing from N3936:

equal_to<void>
not_equal_to<void>
greater<void>
less<void>
greater_equal<void>
less_equal<void>

Can this be fixed editorially? We've already voted the edits in. (I am not concerned with whether this can be fixed between the C++14 DIS and IS; only the WP matters to me.)
@sdutoit sdutoit added this to the 2014 pre-Rapperswil Mailing milestone Mar 29, 2014
zygoloid added a commit that referenced this issue Aug 26, 2014
@zygoloid
Fix to 2013-09 LWG Motion 7:
62734eb 
[comparisons] Fix incorrect application of N3789 to the working paper:
  - Add 'constexpr' to
      std::equal_to<>::operator()
      std::not_equal_to<>::operator()
      std::greater<>::operator()
      std::less<>::operator()
      std::greater_equal<>::operator()
      std::less_equal<>::operator()
  - Reorder 'bool constexpr' to 'constexpr bool' in
      std::logical_or<T>::operator()
      std::logical_and<T>::operator()
      std::logical_not<T>::operator()

Also fixes 14882:2014 DIS JP 08, fixes 14882:2014 DIS JP 09, fixes #291.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2014 pre-Rapperswil Mailing
Development

No branches or pull requests
1 participant
@sdutoit